[Lldb-commits] [PATCH] AArch64 LLDB Support for aarch64-linux-gnu abi support (SysV)

Ed Maste emaste at freebsd.org
Mon Mar 23 07:09:41 PDT 2015


The comment says 'aarch64-linux-gnu' ABI support -- this should be "AArch64 ABI" or "AArch64 SysV ABI", no?

You need to handle aarch64 in the other case in `CreateRegisterContextForFrame` as well.


================
Comment at: source/Plugins/Process/elf-core/ThreadElfCore.cpp:129-131
@@ -127,2 +128,5 @@
                         break;
+                    case llvm::Triple::aarch64:
+                        reg_interface = new RegisterContextLinux_arm64(arch);
+                        break;
                     default:
----------------
please put in alpha order

http://reviews.llvm.org/D8538

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list