[Lldb-commits] [PATCH] Fix for aarch64 lldb-server native builds

Renato Golin renato.golin at linaro.org
Sat Mar 21 08:38:33 PDT 2015


In http://reviews.llvm.org/D8447#143662, @zturner wrote:

> I still think this needs to be fixed in LLVM and not in LLDB.  CMAKE_LIBRARY_ARCHITECTURE is a variable that any library, not just LLDB, might want to check.  And if it's not correct in LLDB, then it's not going to be correct anywhere else either.


I can't find CMAKE_LIBRARY_ARCHITECTURE anywhere else in the LLVM projects... But since this is a CMAKE variable, not an LLVM one, we may need to set it with the host triple, so that it's correct for all projects that might need it in the future.

Omair,

What about setting that variable with the result of LLVM_HOST_TRIPLE set at LLVM src/cmake/config-ix.cmake line 324? Maybe adding a line right after it to set should do the trick.
cheers,
--renato


http://reviews.llvm.org/D8447

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list