[Lldb-commits] [PATCH] expose 64 bit addresses through MI

Ilia K ki.stfu at gmail.com
Thu Mar 19 03:28:50 PDT 2015


lgtm apart few comments


================
Comment at: tools/lldb-mi/MICmdCmdData.cpp:21
@@ -20,2 +20,3 @@
 // Third Party Headers:
+#include <inttypes.h> //PRIx64
 #include "lldb/API/SBThread.h"
----------------
#include <inttypes.h> // For PRIx64

================
Comment at: tools/lldb-mi/MICmdCmdGdbInfo.cpp:13
@@ -12,2 +12,3 @@
 // Third party headers:
+#include <inttypes.h> //PRIx64
 #include "lldb/API/SBCommandReturnObject.h"
----------------
#include <inttypes.h> // For PRIx64

================
Comment at: tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp:11
@@ -10,2 +10,3 @@
 // Third party headers:
+#include <inttypes.h> //PRIx64
 #include "lldb/API/SBThread.h"
----------------
#include <inttypes.h> // For PRIx64

================
Comment at: tools/lldb-mi/MICmnResources.cpp:11
@@ -10,2 +10,3 @@
 // Third party headers
+#include <inttypes.h> //PRIx64
 #include "assert.h"
----------------
#include <inttypes.h> // For PRIx64

http://reviews.llvm.org/D8238

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list