[Lldb-commits] [PATCH] Fix handling of CommandInterpreter's events in lldb-mi

Hafiz Abid Qadeer abidh.haq at gmail.com
Thu Mar 19 02:52:42 PDT 2015


MI part look ok. Greg will have to approve the API part.

> (gdb)

> *stopped,reason="breakpoint-hit"

> (gdb)<press Enter>


Even with this patch, we still need to press enter once to exit as other thread has been blocked in fgets. So we will  keep handling the "quit" in MI as we do currently.

> MI: Program exited OK


I think we should remove this message.


================
Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:300
@@ -299,2 +299,3 @@
     bOk = bOk && RegisterForEvent(strDbgId, CMIUtilString(lldb::SBCommandInterpreter::GetBroadcasterClass()), eventMask);
+    m_lldbDebugger.GetCommandInterpreter().GetBroadcaster().CheckInWithManager();
 
----------------
Why we have to do this for command interpreter?

http://reviews.llvm.org/D8382

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list