[Lldb-commits] [PATCH] Enable TestDataFormatterStdMap on linux (libstdc++) with clang.

[Siva Chandra]

Hi vharron,

This test should have been enabled along with
7181dae1248cc1b03505cca1b7c6e3dfeffefc0a, but since the test was
actually crashing, I thought it was a much deeper problem. Turns out,
all I had to do was to add "-fno-limit-debug-info" when compiling
the test case.

The test is still skipped when the testcase is compiled with GCC.

http://reviews.llvm.org/D8364

Files:
  test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile
  test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py

Index: test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile
===================================================================
--- test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile
+++ test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile
@@ -4,4 +4,11 @@
 
 USE_LIBSTDCPP := 1
 
+# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
+# targets.  Other targets do not, which causes this test to fail.
+# This flag enables FullDebugInfo for all targets.
+ifneq (,$(findstring clang,$(CC)))
+  CFLAGS_EXTRAS += -fno-limit-debug-info
+endif
+
 include $(LEVEL)/Makefile.rules
Index: test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py
===================================================================
--- test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py
+++ test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py
@@ -24,10 +24,6 @@
     @expectedFailureIcc   # llvm.org/pr15301: LLDB prints incorrect size of
                           # libstdc++ containers
     @skipIfFreeBSD
-    @skipIfLinux # non-core functionality, need to reenable and fix
-                 # later (DES 2014.11.07). Most likely failing because
-                 # of mis-match is version of libstdc++ supported by
-                 # the data-formatters.
     @dwarf_test
     def test_with_dwarf_and_run_command(self):
         """Test data formatter commands."""

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8364.22052.patch
Type: text/x-patch
Size: 1562 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150316/308c67e1/attachment.bin>