[Lldb-commits] [PATCH] Add SBArgs to the public interface

[Enrico Granata]

> On Mar 11, 2015, at 1:53 PM, Zachary Turner <zturner at google.com> wrote:
> 
> Hi granata.enrico,
> 
> I found a bug in SetCommandString() which I plan to fix in a separate patch.  I sat down to write a test for the bug and realized there was no SBArgs.  So this adds SBArgs so that we can make sure this kind of thing doesn't happen again in the future.  Here's an output of my command session verifying that it works as expected.
> 
> d:\src\llvmbuild\ninja>bin\lldb
> (lldb) script
> Python Interactive Interpreter. To exit, type 'quit()', 'exit()' or Ctrl-D.
>>>> import lldb
>>>> args = lldb.SBArgs()
>>>> args.SetCommandString("This is a test")
>>>> args.GetArgumentCount()
> 4L
>>>> args.GetArgumentAtIndex(2)
> 'a'
>>>> args.GetArgumentAtIndex(3)
> 'test'
>>>> quit
> (lldb) quit
> 
> http://reviews.llvm.org/D8265
> 
> Files:
>  include/lldb/API/SBArgs.h
>  include/lldb/API/SBDefines.h
>  scripts/Python/interface/SBArgs.i
>  scripts/lldb.swig
>  source/API/CMakeLists.txt
>  source/API/SBArgs.cpp
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> <D8265.21761.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

SB API is more of Greg’s area - I would add him to the reviewers for this