[Lldb-commits] [PATCH] Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS

[Hafiz Abid Qadeer]

In http://reviews.llvm.org/D8210#139039, @ChuckR wrote:

> In http://reviews.llvm.org/D8210#138718, @ki.stfu wrote:
>
> > In http://reviews.llvm.org/D8210#138716, @abidh wrote:
> >
> > > In http://reviews.llvm.org/D8210#138699, @ki.stfu wrote:
> > >
> > > > In http://reviews.llvm.org/D8210#138690, @abidh wrote:
> > > >
> > > > > I personally don't like using "-interpreter-exec" when there are proper MI commands available to do the job. But if start adding option/commands in lldb-mi for every options available in lldb proper then it will also get a little messy. Would it work for you to use "-interpreter-exec" as Ilia suggested above?
> > > >
> > > >
> > > > I don't insist on it if these options are well-known. As I said I don't see them in description of -file-exec-and-symbols command.
> > >
> > >
> > > These options are not standard MI options. ChuckR is probably trying to add in lldb-mi what he see in "Target Create" command in lldb.
> >
> >
> > Then I dislike this patch. I'm not sure that we should add custom options. Is there another way to do it?
>
>
> I could not find another way to do this. I agree with jignham that if the answer is to use interpret-exec, then there is a gap in the MI options. interpret-exec- output is harder to parse and is means the consumer of lldb-mi must add additional logic. While these are not officially documented flags in the gdb-mi docs, I do not think that should stop us from adding to lldb-mi where needed. I am happy to talk about a more organized way to add this ability, but simply saying this isn't in the gdb docs so we can't do it doesn't seem like a good answer.




In http://reviews.llvm.org/D8210#139039, @ChuckR wrote:

> In http://reviews.llvm.org/D8210#138718, @ki.stfu wrote:
>
> > In http://reviews.llvm.org/D8210#138716, @abidh wrote:
> >
> > > In http://reviews.llvm.org/D8210#138699, @ki.stfu wrote:
> > >
> > > > In http://reviews.llvm.org/D8210#138690, @abidh wrote:
> > > >
> > > > > I personally don't like using "-interpreter-exec" when there are proper MI commands available to do the job. But if start adding option/commands in lldb-mi for every options available in lldb proper then it will also get a little messy. Would it work for you to use "-interpreter-exec" as Ilia suggested above?
> > > >
> > > >
> > > > I don't insist on it if these options are well-known. As I said I don't see them in description of -file-exec-and-symbols command.
> > >
> > >
> > > These options are not standard MI options. ChuckR is probably trying to add in lldb-mi what he see in "Target Create" command in lldb.
> >
> >
> > Then I dislike this patch. I'm not sure that we should add custom options. Is there another way to do it?
>
>
> I could not find another way to do this. I agree with jignham that if the answer is to use interpret-exec, then there is a gap in the MI options. interpret-exec- output is harder to parse and is means the consumer of lldb-mi must add additional logic. While these are not officially documented flags in the gdb-mi docs, I do not think that should stop us from adding to lldb-mi where needed. I am happy to talk about a more organized way to add this ability, but simply saying this isn't in the gdb docs so we can't do it doesn't seem like a good answer.


I am all for adding new options if that make sense. But these options should be properly thought out as they get baked into the clients and then become difficult to change. So please address the comments by the other reviews and add a new text file in lldb-mi which documents these new options.


http://reviews.llvm.org/D8210

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/