[Lldb-commits] [PATCH] Skip AsanTestCase and AsanTestReportDataCase on Darwin

[Ilia K]

I added @skipUnlessCompilerRt decorator. At the moment, if you have compiler-rt support then these tests pass:

  $ ./dotest.py -v --executable $BUILDDIR/bin/lldb functionalities/asan/
  ...
  1: test_with_dsym (TestMemoryHistory.AsanTestCase) ... AddressSanitizer debugger support is active. Memory error breakpoint has been installed and you can now use the 'memory history' command.
  AddressSanitizer debugger support is active. Memory error breakpoint has been installed and you can now use the 'memory history' command.
  ok
  2: test_with_dwarf (TestMemoryHistory.AsanTestCase) ... AddressSanitizer debugger support is active. Memory error breakpoint has been installed and you can now use the 'memory history' command.
  AddressSanitizer debugger support is active. Memory error breakpoint has been installed and you can now use the 'memory history' command.
  ok
  3: test_with_dsym (TestReportData.AsanTestReportDataCase) ... AddressSanitizer debugger support is active. Memory error breakpoint has been installed and you can now use the 'memory history' command.
  AddressSanitizer debugger support is active. Memory error breakpoint has been installed and you can now use the 'memory history' command.
  AddressSanitizer report breakpoint hit. Use 'thread info -s' to get extended information about the report.
  ok
  4: test_with_dwarf (TestReportData.AsanTestReportDataCase) ... AddressSanitizer debugger support is active. Memory error breakpoint has been installed and you can now use the 'memory history' command.
  AddressSanitizer debugger support is active. Memory error breakpoint has been installed and you can now use the 'memory history' command.
  AddressSanitizer report breakpoint hit. Use 'thread info -s' to get extended information about the report.
  ok
  
  ----------------------------------------------------------------------
  Ran 4 tests in 18.729s
  
  OK

But if you don't then tests are ignored:

  $ ./dotest.py -v --executable $BUILDDIR/bin/lldb functionalities/asan/
  ...
  1: test_with_dsym (TestMemoryHistory.AsanTestCase) ... skipped 'skip if compiler-rt not found'
  2: test_with_dwarf (TestMemoryHistory.AsanTestCase) ... skipped 'skip if compiler-rt not found'
  3: test_with_dsym (TestReportData.AsanTestReportDataCase) ... skipped 'skip if compiler-rt not found'
  4: test_with_dwarf (TestReportData.AsanTestReportDataCase) ... skipped 'skip if compiler-rt not found'
  
  ----------------------------------------------------------------------
  Ran 4 tests in 0.071s
  
  OK (skipped=4)


http://reviews.llvm.org/D7958

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/