[Lldb-commits] [PATCH] Initialize ProcessGDBRemoteLog for LLGS to fix remote platform logging

Tamas Berghammer tberghammer at google.com
Wed Mar 11 03:17:37 PDT 2015


Please update ProcessFreeBSD::Initialize() to use the newly created ProcessPOSIXLog::Initialize() function.


REPOSITORY
  rL LLVM

================
Comment at: source/Plugins/Process/Linux/ProcessLinux.cpp:64
@@ -71,2 +63,3 @@
+        ProcessPOSIXLog::Initialize();
         ProcessPOSIXLog::RegisterPluginName(GetPluginNameStatic());
     }
----------------
Please move this line into ProcessPOSIXLog::Initialize()

================
Comment at: source/Plugins/Process/POSIX/ProcessPOSIXLog.cpp:41
@@ +40,3 @@
+{
+    static ConstString g_name("linux");
+    static std::once_flag g_once_flag;
----------------
Please make it an argument, instead of a hard coded string.

http://reviews.llvm.org/D8186

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list