[Lldb-commits] [PATCH] Pass a process full executable path within "name" response field.

Oleksiy Vyalov ovyalov at google.com
Tue Mar 10 17:08:10 PDT 2015


Hi clayborg, vharron,

Pass a full executable path within "name" response field for q*ProcessInfo commands so lldb host can get a full executable path for a process.
Client side already expects this field to be a full path - "process_info.GetExecutableFile().SetFile (value.c_str(), false);" - https://github.com/llvm-mirror/lldb/blob/master/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp#L2356

http://reviews.llvm.org/D8239

Files:
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp

Index: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
===================================================================
--- source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
+++ source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
@@ -1195,7 +1195,7 @@
                      proc_info.GetEffectiveUserID(),
                      proc_info.GetEffectiveGroupID());
     response.PutCString ("name:");
-    response.PutCStringAsRawHex8(proc_info.GetName());
+    response.PutCStringAsRawHex8(proc_info.GetExecutableFile().GetPath().c_str());
     response.PutChar(';');
     const ArchSpec &proc_arch = proc_info.GetArchitecture();
     if (proc_arch.IsValid())

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8239.21661.patch
Type: text/x-patch
Size: 730 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150311/48df6246/attachment.bin>


More information about the lldb-commits mailing list