[Lldb-commits] [PATCH] Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS

[Greg Clayton]

Looks good except the launch code. See my inlined comment. BTW: to make inline comments in the code, you click and drag in the line numbers column and let go and then you can comment on specific bits of code.


================
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:96-110
@@ -98,1 +95,17 @@
+    
+    lldb::SBProcess process;
+    if (rSessionInfo.GetProcess().IsValid() && rSessionInfo.GetProcess().GetState() == lldb::StateType::eStateConnected)
+    {
+        // remote process that has not yet been launched
+        uint32_t launch_flags = lldb::LaunchFlags::eLaunchFlagDebug | lldb::LaunchFlags::eLaunchFlagDisableSTDIO;
+        process = rSessionInfo.GetProcess();
+        process.RemoteLaunch(nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, launch_flags, false, error);
+    }
+    else
+    {
+        lldb::SBLaunchInfo launchInfo = rSessionInfo.GetTarget().GetLaunchInfo();
+        launchInfo.SetListener(rSessionInfo.GetListener());
+        process = rSessionInfo.GetTarget().Launch(launchInfo, error);
+    }
+
     if ((!process.IsValid()) || (error.Fail()))
----------------
You shouldn't have to do this, you should be able to leave the code like it was before.

http://reviews.llvm.org/D8210

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/