[Lldb-commits] [PATCH] Initialize ProcessGDBRemoteLog for LLGS by GDBRemoteCommunication::Initialize

[Tamas Berghammer]

REPOSITORY
  rL LLVM

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:142
@@ +141,3 @@
+void
+GDBRemoteCommunication::Initialize()
+{
----------------
ovyalov wrote:
> Maybe introduce ProcessGDBRemoteLog::Initialize() instead of this method?
> 
> We can put 
> 
> 
> ```
> Log::Callbacks log_callbacks = {
>             ProcessGDBRemoteLog::DisableLog,
>             ProcessGDBRemoteLog::EnableLog,
>             ProcessGDBRemoteLog::ListLogCategories
>         };
> 
>         Log::RegisterLogChannel (g_name, log_callbacks);
> ```
> 
> inside of ProcessGDBRemoteLog::Initialize and call it from ProcessGDBRemote::Initialize and lldb-server.cpp.
I like your idea about creating ProcessGDBRemoteLog::Initialize, but I would prefer to call it from lldb.cpp:initializeLLGS().

http://reviews.llvm.org/D8186

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/