[Lldb-commits] [PATCH] [MIPS] - Register Context for MIPS64

Tamas Berghammer tberghammer at google.com
Mon Mar 9 09:57:45 PDT 2015


The integration into NativeThread and NativeProcess looks good.


REPOSITORY
  rL LLVM

================
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:100-112
@@ +99,15 @@
+
+uint32_t
+NativeRegisterContextLinux_mips64::GetRegisterSetCount () const
+{
+    uint32_t sets = 0;
+    
+    for (uint32_t set_index = 0; set_index < k_num_register_sets; ++set_index)
+    {
+        if (set_index < k_num_register_sets)
+            ++sets;
+    }
+
+    return sets;
+}
+
----------------
Please simplify it. I think it should be just a "return k_num_register_sets;"

http://reviews.llvm.org/D8166

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list