[Lldb-commits] [PATCH] Can't set watchpoints on launching threads on Linux LLGS.

[Chaoren Lin]

> Yes, it's safe to send PTRACE request to a thread when it in stopped
state.

But is it *only* the stopped state? It shouldn't be possible to set a
watchpoint in any other state right?

> How do you reproduce this situation with setting watchpoint on a running
thread?

TestSetWatchlocation and TestTargetWatchAddress both occasionally fail due
to this. It manifests as failing to set watchpoint. The threads should have
been stopped, but they're still eStateRunning when the process tried to set
watchpoints.
On Mar 5, 2015 18:28, "Oleksiy Vyalov" <ovyalov at google.com> wrote:

> In http://reviews.llvm.org/D7914#135266, @chaoren wrote:
>
> > It seems like the only state in which it's possible to set a hardware
> watchpoint is eStateStopped. All other states either can't be examined by
> ptrace or has already crashed. Am I understanding this correctly? Right now
> I'm running into a problem where watchpoint is being set while the state is
> eStateRunning. That's a probably caused by an unrelated problem of threads
> failing to be stopped.
>
>
> Yes, it's safe to send PTRACE request to a thread when it in stopped
> state. How do you reproduce this situation with setting watchpoint on a
> running thread?
>
>
> http://reviews.llvm.org/D7914
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150305/058b3d8c/attachment.html>