[Lldb-commits] [PATCH] Python Split [2/2] - Content change

[Zachary Turner]

I think this part needs to be done as a separate patch.  Makes it easier to
review and understand the impact of.  So I will do this part first
(basically delete ScriptInterpreterObject and move everything to
StructuredData) and commit that, then rebase this on top of that and go
from there.

On Thu, Mar 5, 2015 at 2:37 PM Greg Clayton <clayborg at gmail.com> wrote:

> So seems like part of the work required for this patch to work is to
> change any references in code from PythonList, PythonString, PythonInteger,
> and PythonDictionary to use classes from lldb/Core/StructuredData.h.
>
> The means we probably need to have OperatingSystemPython rely only upon
> virtual functions in ScriptInterpreter and have those functions return
> stuff from StructuredData instead of python variants:
>
>   PythonDictionary dictionary(m_interpreter->OSPlugin_RegisterInfo(m_
> python_object_sp));
>
> Will need to become:
>
>   StructuredData::Dictionary dictionary(m_interpreter->
> OSPlugin_RegisterInfo(m_python_object_sp));
>
> We then need to modify the Python callbacks that return PythonList,
> PythonString, PythonInteger, and PythonDictionary objects, to convert them
> into StructuredData::Array, StructuredData::String, StructuredData::Integer
> and StructuredData::Dictionary respectively.
>
>
> http://reviews.llvm.org/D7957
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150306/5a175fcb/attachment.html>