[Lldb-commits] [PATCH] Create NativeRegisterContext for android-arm64

Vince Harron vharron at google.com
Wed Mar 4 18:51:47 PST 2015


================
Comment at: source/Plugins/Process/Linux/ProcessMonitor.cpp:51
@@ -53,1 +50,3 @@
 
+#ifndef __ANDROID__
+#include <sys/procfs.h>
----------------
tberghammer wrote:
> vharron wrote:
> > duplicate block of defines should be moved into common header?
> Will fix it tomorrow.
> Do you have any suggestion for the name and location of the file (AndroidProcfs_arm64)?
source/Plugins/Process/Linux/Procfs.h

Comment in the header:

source/Plugins/Process/Linux/Procfs.h defines the symbols we need from Procfs.h on Android/Linux for all supported architectures.

nit: I would always to positive case first

e.g. 

#ifdef __ANDROID__

is easier to read than 

#ifndef __ANDROID__

http://reviews.llvm.org/D8058

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list