[Lldb-commits] [PATCH] Fix deadlock in operation thread in NativeProcessLinux

Tamas Berghammer tberghammer at google.com
Wed Mar 4 03:02:16 PST 2015


================
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:3563
@@ -3558,3 +3562,3 @@
     {
         m_monitor_thread.Cancel();
         m_monitor_thread.Join(nullptr);
----------------
ovyalov wrote:
> Monitoring thread uses Cancel as well - should we redesign it for Android? 
In long run possibly yes, but it already have a lot of logic to stop it in different cases and I haven't seen a case when the cancel is actually have effect yet. I have a design to replace it on android but it is a bit nasty so I hold it back until it isn't cause any issue with the hope that we will find a better solution.

http://reviews.llvm.org/D8030

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list