[Lldb-commits] [PATCH] Fix TestQuoting on remote targets.

[Greg Clayton]

Check my inline comments.


================
Comment at: test/settings/quoting/TestQuoting.py:72
@@ +71,3 @@
+        if lldb.remote_platform:
+            src_file_spec = lldb.SBFileSpec('stdout.txt', True)
+            dst_file_spec = lldb.SBFileSpec('stdout.txt', False)
----------------
Shouldn't this be set to "False" to not resolve the remote copy? Isn't "src_file_spec" the remote path?

================
Comment at: test/settings/quoting/TestQuoting.py:73
@@ +72,3 @@
+            src_file_spec = lldb.SBFileSpec('stdout.txt', True)
+            dst_file_spec = lldb.SBFileSpec('stdout.txt', False)
+            lldb.remote_platform.Get(src_file_spec, dst_file_spec);
----------------
Isn't this the local copy of the file and so it should be resolved?

http://reviews.llvm.org/D8023

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/