[Lldb-commits] [PATCH] Set the signals based on the OS in the qHostInfo packet

Tamas Berghammer tberghammer at google.com
Tue Mar 3 08:35:13 PST 2015


Hi vharron, clayborg,

Set the signals based on the OS in the qHostInfo packet

Setting it from the Target architecture cause problems when the target architecture is filled just by examining the executable because in that case the OS isn't set.

http://reviews.llvm.org/D8035

Files:
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

Index: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
===================================================================
--- source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
+++ source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
@@ -703,7 +703,7 @@
     // FIXME Add a gdb-remote packet to discover dynamically.
     if (error.Success ())
     {
-        const ArchSpec arch_spec = GetTarget ().GetArchitecture ();
+        const ArchSpec arch_spec = m_gdb_comm.GetHostArchitecture();
         if (arch_spec.IsValid ())
         {
             if (log)

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8035.21108.patch
Type: text/x-patch
Size: 572 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150303/cde0ae50/attachment.bin>


More information about the lldb-commits mailing list