[Lldb-commits] [PATCH] Fix TestQuoting on remote targets.

Oleksiy Vyalov ovyalov at google.com
Mon Mar 2 18:14:54 PST 2015


Please see my comments.


================
Comment at: test/settings/quoting/TestQuoting.py:71
@@ -70,1 +70,3 @@
 
+        platform = self.dbg.GetSelectedPlatform();
+        src_file_spec = lldb.SBFileSpec('stdout.txt', True)
----------------
No need for semicolon

================
Comment at: test/settings/quoting/TestQuoting.py:74
@@ -71,1 +73,3 @@
+        dst_file_spec = lldb.SBFileSpec('stdout.txt', False)
+        platform.Get(src_file_spec, dst_file_spec);
         with open('stdout.txt', 'r') as f:
----------------
Does it work in case of local run? It seems it might read and write data from/into the same file..

http://reviews.llvm.org/D8023

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list