[Lldb-commits] [PATCH] Fix execution of platform shell commands on android

[Pavel Labath]

Looks good overall, but I have a couple of comments...


REPOSITORY
  rL LLVM

================
Comment at: include/lldb/Host/android/HostInfoAndroid.h:26
@@ -25,3 +22,4 @@
-    ~HostInfoAndroid();
+  public:
+    static FileSpec GetDefaultShell();
 
   protected:
----------------
How is the constructor removal related to the rest of the patch?

================
Comment at: source/Host/android/ProcessLauncherAndroid.cpp:42
@@ +41,3 @@
+    const static char* path = "PATH=";
+    const static int path_len = strlen(path);
+    for (const char** args = env.GetConstArgumentVector(); *args; ++args)
----------------
Storage specifiers (static) are usually placed before the type (including the "const" keyword).

http://reviews.llvm.org/D8009

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/