[Lldb-commits] [PATCH] Fix failing tests caused by lack of default debug info

Siva Chandra sivachandra at google.com
Fri Feb 27 12:47:56 PST 2015


LGTM.

What I would really love to see is more descriptive commit message headers which are not one-line monsters. Most definitely up to you, but how about

"Use -fstandalone-debug for few tests to get around a Clang optimization."


================
Comment at: test/lldbtest.py:560
@@ -561,1 +559,3 @@
+def expectedFailureClang(bugnumber=None, compiler_version=None):
+    if bugnumber: return expectedFailureCompiler('clang', compiler_version, bugnumber)
 
----------------
Up to you, but this should probably be a different change, in line with my subject line suggestion.

http://reviews.llvm.org/D7948

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list