[Lldb-commits] [lldb] r230691 - Add synchronization to TestWatchLocation.

Chaoren Lin chaorenl at google.com
Thu Feb 26 13:31:27 PST 2015


Author: chaoren
Date: Thu Feb 26 15:31:27 2015
New Revision: 230691

URL: http://llvm.org/viewvc/llvm-project?rev=230691&view=rev
Log:
Add synchronization to TestWatchLocation.

Summary:
There was no guarantee that the three threads haven't already exited by the
time the watchpoint is set.

Reviewers: ovyalov

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D7916

Modified:
    lldb/trunk/test/functionalities/watchpoint/hello_watchlocation/main.cpp

Modified: lldb/trunk/test/functionalities/watchpoint/hello_watchlocation/main.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/watchpoint/hello_watchlocation/main.cpp?rev=230691&r1=230690&r2=230691&view=diff
==============================================================================
--- lldb/trunk/test/functionalities/watchpoint/hello_watchlocation/main.cpp (original)
+++ lldb/trunk/test/functionalities/watchpoint/hello_watchlocation/main.cpp Thu Feb 26 15:31:27 2015
@@ -18,6 +18,8 @@ pthread_t g_thread_1 = NULL;
 pthread_t g_thread_2 = NULL;
 pthread_t g_thread_3 = NULL;
 
+pthread_barrier_t g_barrier;
+
 char *g_char_ptr = NULL;
 
 void
@@ -52,6 +54,8 @@ thread_func (void *arg)
     uint32_t thread_index = *((uint32_t *)arg);
     printf ("%s (thread index = %u) startng...\n", __FUNCTION__, thread_index);
 
+    pthread_barrier_wait(&g_barrier);
+
     uint32_t count = 0;
     uint32_t val;
     while (count++ < 15)
@@ -84,17 +88,23 @@ int main (int argc, char const *argv[])
     g_char_ptr = (char *)malloc (1);
     *g_char_ptr = 0;
 
+    pthread_barrier_init(&g_barrier, NULL, 4);
+
     // Create 3 threads
     err = ::pthread_create (&g_thread_1, NULL, thread_func, &thread_index_1);
     err = ::pthread_create (&g_thread_2, NULL, thread_func, &thread_index_2);
     err = ::pthread_create (&g_thread_3, NULL, thread_func, &thread_index_3);
 
     printf ("Before turning all three threads loose...\n"); // Set break point at this line.
+    pthread_barrier_wait(&g_barrier);
 
     // Join all of our threads
     err = ::pthread_join (g_thread_1, &thread_result);
     err = ::pthread_join (g_thread_2, &thread_result);
     err = ::pthread_join (g_thread_3, &thread_result);
 
+    pthread_barrier_destroy(&g_barrier);
+    free(g_char_ptr);
+
     return 0;
 }





More information about the lldb-commits mailing list