[Lldb-commits] [PATCH] Can't set watchpoints on launching threads on Linux LLGS.

Chaoren Lin chaorenl at google.com
Thu Feb 26 11:21:30 PST 2015


Hi ovyalov,

They'll be set anyway when the thread starts running, so the launching threads
should just ignore the set request.

http://reviews.llvm.org/D7914

Files:
  source/Plugins/Process/Linux/NativeThreadLinux.cpp

Index: source/Plugins/Process/Linux/NativeThreadLinux.cpp
===================================================================
--- source/Plugins/Process/Linux/NativeThreadLinux.cpp
+++ source/Plugins/Process/Linux/NativeThreadLinux.cpp
@@ -218,6 +218,8 @@
 {
     if (!hardware)
         return Error ("not implemented");
+    if (m_state == eStateLaunching)
+        return Error ();
     Error error = RemoveWatchpoint(addr);
     if (error.Fail()) return error;
     NativeRegisterContextSP reg_ctx = GetRegisterContext ();

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7914.20781.patch
Type: text/x-patch
Size: 527 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150226/25642f02/attachment.bin>


More information about the lldb-commits mailing list