[Lldb-commits] [PATCH] Reduce the number of components initialized by lldb-server to reduce static binary size.

Tamas Berghammer tberghammer at google.com
Wed Feb 25 07:38:27 PST 2015


Please do the same separation for the Terminate methods also. In most of the case (probably all) it is ensured that calling Terminate without Initialize won't cause any problem but I think it is a very bad practice to rely on this behavior and I expect some further reduction in size from that change.


REPOSITORY
  rL LLVM

================
Comment at: tools/lldb-server/lldb-gdbserver.cpp:510-511
@@ -509,4 +509,2 @@
 
-    Debugger::Initialize (NULL);
-
     lldb::DebuggerSP debugger_sp = Debugger::CreateInstance ();
----------------
Are you sure you don't have to initialize the debugger?

http://reviews.llvm.org/D7880

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list