[Lldb-commits] [PATCH] Remove use_pthread option from getBuildFlags in the test environment

Tamas Berghammer tberghammer at google.com
Wed Feb 25 05:28:49 PST 2015


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7861

Files:
  lldb/trunk/test/functionalities/thread/create_after_attach/Makefile
  lldb/trunk/test/functionalities/thread/exit_during_step/Makefile
  lldb/trunk/test/functionalities/thread/jump/Makefile
  lldb/trunk/test/functionalities/thread/thread_exit/Makefile
  lldb/trunk/test/lldbtest.py

Index: lldb/trunk/test/functionalities/thread/jump/Makefile
===================================================================
--- lldb/trunk/test/functionalities/thread/jump/Makefile
+++ lldb/trunk/test/functionalities/thread/jump/Makefile
@@ -1,4 +1,5 @@
 LEVEL = ../../../make
 
+ENABLE_THREADS := YES
 CXX_SOURCES := main.cpp other.cpp
 include $(LEVEL)/Makefile.rules
Index: lldb/trunk/test/functionalities/thread/exit_during_step/Makefile
===================================================================
--- lldb/trunk/test/functionalities/thread/exit_during_step/Makefile
+++ lldb/trunk/test/functionalities/thread/exit_during_step/Makefile
@@ -1,4 +1,5 @@
 LEVEL = ../../../make
 
+ENABLE_THREADS := YES
 CXX_SOURCES := main.cpp
 include $(LEVEL)/Makefile.rules
Index: lldb/trunk/test/functionalities/thread/thread_exit/Makefile
===================================================================
--- lldb/trunk/test/functionalities/thread/thread_exit/Makefile
+++ lldb/trunk/test/functionalities/thread/thread_exit/Makefile
@@ -1,4 +1,5 @@
 LEVEL = ../../../make
 
+ENABLE_THREADS := YES
 CXX_SOURCES := main.cpp
 include $(LEVEL)/Makefile.rules
Index: lldb/trunk/test/functionalities/thread/create_after_attach/Makefile
===================================================================
--- lldb/trunk/test/functionalities/thread/create_after_attach/Makefile
+++ lldb/trunk/test/functionalities/thread/create_after_attach/Makefile
@@ -1,4 +1,5 @@
 LEVEL = ../../../make
 
+ENABLE_THREADS := YES
 C_SOURCES := main.c
 include $(LEVEL)/Makefile.rules
Index: lldb/trunk/test/lldbtest.py
===================================================================
--- lldb/trunk/test/lldbtest.py
+++ lldb/trunk/test/lldbtest.py
@@ -1525,11 +1525,12 @@
         
         return os.environ["CC"]
 
-    def getBuildFlags(self, use_cpp11=True, use_libcxx=False, use_libstdcxx=False, use_pthreads=True):
+    def getBuildFlags(self, use_cpp11=True, use_libcxx=False, use_libstdcxx=False):
         """ Returns a dictionary (which can be provided to build* functions above) which
             contains OS-specific build flags.
         """
         cflags = ""
+        ldflags = ""
 
         # On Mac OS X, unless specifically requested to use libstdc++, use libc++
         if not use_libstdcxx and sys.platform.startswith('darwin'):
@@ -1554,9 +1555,6 @@
         elif "clang" in self.getCompiler():
             cflags += " -stdlib=libstdc++"
 
-        if use_pthreads:
-            ldflags = "-lpthread"
-
         return {'CFLAGS_EXTRAS' : cflags,
                 'LD_EXTRAS' : ldflags,
                }

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7861.20668.patch
Type: text/x-patch
Size: 2613 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150225/3d3d44fa/attachment.bin>


More information about the lldb-commits mailing list