[Lldb-commits] [PATCH] Create ScopedTimeout class for GDBRemoteCommunication

Tamas Berghammer tberghammer at google.com
Tue Feb 24 02:25:09 PST 2015


================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:934
@@ +933,3 @@
+{
+    m_saved_timeout = m_gdb_comm.SetPacketTimeout (timeout);
+}
----------------
ovyalov wrote:
> You may put this statement in initializer list and make m_saved_timeout const;
I would prefer to leave it here because I think it is a bit cleaner (don't like complex expressions in the initializer list) and making it const don't make that big effect in a such simple class.

http://reviews.llvm.org/D7826

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list