[Lldb-commits] [PATCH] Skip symlinks to the original file when searching for debug info

[Zachary Turner]

In http://reviews.llvm.org/D7836#128456, @jingham wrote:

> Shouldn't this be a method on FileSpec.  It would be fine to back it with the llvm function, but it's weird to have to use a mixture of FileSpec & lower-level llvm file system calls.
>
> Jim


I'm actually a fan of the lower level file-system api calls because it makes it clear to the reader that host-specific code is going to execute.  I actually wish FileSpec didn't even expose any host-specific operations, but it's hard to revisit that design now that it's in the public api.  There's Host::FileSystem which could be a good place for it.  But I kind of don't like the idea of FileSpec exposing a method that actually hits the host file system.  It's kind of a fine line, I agree, but I just envision FileSpec as something that manipulates paths.  This opens up the possibility of using FileSpecs to represent paths on remote hosts, for example.


http://reviews.llvm.org/D7836

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/