[Lldb-commits] [PATCH] Move the shell expansion code to Host/common

[Zachary Turner]

Hi granata.enrico, clayborg, sivachandra,

This moves the shell expansion code from different implementation files for every Host to Host/common.  The reason for this is that the method for expanding the shell arguments is the same for a majority of platforms, so there is no reason to leave it unimplemented for everyone.

Additionally, this generalizes the Host method a little to be useful even if you don't have a ProcessLaunchInfo handy by changing the arguments to accept only the information that it needs, instead of the entire ProcessLaunchInfo.  As a side effect, this also fixes a redundant test of the process launch flag, which was being checked once in the Platform and another time in Host::ShellExpandArguments.

http://reviews.llvm.org/D7805

Files:
  include/lldb/API/SBLaunchInfo.h
  include/lldb/Host/Host.h
  include/lldb/Target/Platform.h
  source/Host/common/Host.cpp
  source/Host/freebsd/Host.cpp
  source/Host/linux/Host.cpp
  source/Host/macosx/Host.mm
  source/Host/windows/Host.cpp
  source/Target/Platform.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7805.20454.patch
Type: text/x-patch
Size: 13494 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150221/1b301ac2/attachment.bin>