[Lldb-commits] [lldb] r230082 - Fix TestStubSetSID after unification in to a single lldb-server binary.

Siva Chandra sivachandra at google.com
Fri Feb 20 14:58:00 PST 2015


Author: sivachandra
Date: Fri Feb 20 16:58:00 2015
New Revision: 230082

URL: http://llvm.org/viewvc/llvm-project?rev=230082&view=rev
Log:
Fix TestStubSetSID after unification in to a single lldb-server binary.

Summary:
lldb-server needs an explicit 'g' or 'p' argument now. Since lldb-server
is started as a gdbserver in this test, 'g' should be passed to it
explicitly.

Test Plan: ./dotest.py -p TestStubSetSID

Reviewers: flackr, ovyalov

Reviewed By: ovyalov

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D7801

Modified:
    lldb/trunk/test/tools/lldb-gdbserver/commandline/TestStubSetSID.py

Modified: lldb/trunk/test/tools/lldb-gdbserver/commandline/TestStubSetSID.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/tools/lldb-gdbserver/commandline/TestStubSetSID.py?rev=230082&r1=230081&r2=230082&view=diff
==============================================================================
--- lldb/trunk/test/tools/lldb-gdbserver/commandline/TestStubSetSID.py (original)
+++ lldb/trunk/test/tools/lldb-gdbserver/commandline/TestStubSetSID.py Fri Feb 20 16:58:00 2015
@@ -13,6 +13,11 @@ import tempfile
 import time
 from lldbtest import *
 
+
+def get_common_stub_args():
+    return [] if 'darwin' in sys.platform else ['g']
+
+
 class TestStubSetSIDTestCase(gdbremote_testcase.GdbRemoteTestCaseBase):
     def get_stub_sid(self, extra_stub_args=None):
         # Launch debugserver
@@ -34,11 +39,11 @@ class TestStubSetSIDTestCase(gdbremote_t
         self.assertEquals(stub_sid, os.getsid(0))
 
     def sid_is_different_with_setsid(self):
-        stub_sid = self.get_stub_sid(" --setsid")
+        stub_sid = self.get_stub_sid(" %s --setsid" % ' '.join(get_common_stub_args()))
         self.assertNotEquals(stub_sid, os.getsid(0))
 
     def sid_is_different_with_S(self):
-        stub_sid = self.get_stub_sid(" -S")
+        stub_sid = self.get_stub_sid(" %s -S" % ' '.join(get_common_stub_args()))
         self.assertNotEquals(stub_sid, os.getsid(0))
 
     @debugserver_test





More information about the lldb-commits mailing list