[Lldb-commits] [PATCH] Increase the timeout for pwrite on android

[Oleksiy Vyalov]

Please see my comments.


================
Comment at: source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp:233
@@ +232,3 @@
+{
+    uint32_t old_packet_timeout = m_gdb_client.SetPacketTimeout (5);
+    uint64_t res = PlatformRemoteGDBServer::WriteFile (fd, offset, src, src_len, error);
----------------
It will be great to have sort of ScopedTimeout class which sets a new timeout in constructor (along with saving a previous old timeout value) and resets old value in destructor.
As I can see such pattern (set new timeout/ restore old timeout)  has a few occurrences 

================
Comment at: source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp:233
@@ +232,3 @@
+{
+    uint32_t old_packet_timeout = m_gdb_client.SetPacketTimeout (5);
+    uint64_t res = PlatformRemoteGDBServer::WriteFile (fd, offset, src, src_len, error);
----------------
ovyalov wrote:
> It will be great to have sort of ScopedTimeout class which sets a new timeout in constructor (along with saving a previous old timeout value) and resets old value in destructor.
> As I can see such pattern (set new timeout/ restore old timeout)  has a few occurrences 
For such request the transfer latency depends on a size of buffer (src_len) - is it possible to make timeout a function of buffer size?

http://reviews.llvm.org/D7788

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/