[Lldb-commits] [PATCH] Add -stack-info-frame command (MI)

[Greg Clayton]

Just a quick reminder you might want to use triple quotes instead of desensitizing every other character in the python test case code.

Looks good otherwise.


================
Comment at: test/tools/lldb-mi/TestMiStack.py:204
@@ +203,3 @@
+        self.runCmd("-stack-info-frame")
+        self.expect("\^error,msg=\"Command 'stack-info-frame'. Invalid process during debug session\"")
+
----------------
Use triple quotes?

 self.expect('''^error,msg="Command 'stack-info-frame'. Invalid process during debug session"''')

================
Comment at: test/tools/lldb-mi/TestMiStack.py:212
@@ +211,3 @@
+        self.runCmd("-break-insert -f main")
+        self.expect("\^done,bkpt={number=\"1\"")
+        self.runCmd("-exec-run")
----------------
Triple quotes?

        self.expect('''^done,bkpt={number="1"''')


================
Comment at: test/tools/lldb-mi/TestMiStack.py:219
@@ +218,3 @@
+        self.runCmd("-stack-info-frame")
+        self.expect("\^done,frame=\{level=\"0\",addr=\".+\",func=\"main\",file=\"main\.c\",fullname=\".*main\.c\",line=\"\d+\"\}")
+
----------------
triple quotes?

http://reviews.llvm.org/D7750

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/