[Lldb-commits] [PATCH] Initial Assembly profiler for mips64

[Greg Clayton]

Patch looks good, but for anything that is playing with instructions, I would prefer if you subclass EmulateInstruction and make an instruction emulator for any instructions you plan on pulling apart. It would be nice to create an EmulateInstructionMIPS64 class that inherits from EmulateInstruction (see the lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp for an example). We might have the need to parse/emulate MIPS64 instructions in other places and placing that parsing code into EmulateInstructionMIPS64 ensure others can re-use your instruction parser for in other places in the code.

See the comments at the top of EmulateInstruction.h for more details and let me know if you have any questions.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7696

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/