[Lldb-commits] [PATCH] Prevent LLGS from crashing when exiting - make NativeProcessLinux to wait until ThreadStateCoordinator is fully stopped before entering ~NativeProcessLinux.

[Jim Ingham]

Be careful about this sort of thing, there are all sorts of gnarly corner cases, like a breakpoint command that does:

(lldb) break command add
Enter your debugger command(s).  Type 'DONE' to end.

> settings set auto-confirm true 

>  process kill 

> DONE


The "process kill" gets executed while you are running through all the threads that have stopped for some reason to figure out what they want to do, and you have to keep enough of the thread alive to successfully get out of that logic.  So you can't just nuke the thread when the process dies or this won't go well.

Jim


http://reviews.llvm.org/D7692

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/