[Lldb-commits] [PATCH] Fix TestRegisters on remote target.

Chaoren Lin chaorenl at google.com
Sun Feb 15 19:04:19 PST 2015


Hi ovyalov, vharron, clayborg,

Using spawnSubprocess instead of forkSubprocess, so that the subprocess
spawns on the target and not the host.

Requires http://reviews.llvm.org/D7660 for cleanup.

http://reviews.llvm.org/D7661

Files:
  test/functionalities/register/TestRegisters.py

Index: test/functionalities/register/TestRegisters.py
===================================================================
--- test/functionalities/register/TestRegisters.py
+++ test/functionalities/register/TestRegisters.py
@@ -252,12 +252,7 @@
         exe = os.path.join(os.getcwd(), "a.out")
 
         # Spawn a new process
-        pid = 0
-        if sys.platform.startswith('linux'):
-            pid = self.forkSubprocess(exe, ['wait_for_attach'])
-        else:
-            proc = self.spawnSubprocess(exe, ['wait_for_attach'])
-            pid = proc.pid
+        pid = self.spawnSubprocess(exe, ['wait_for_attach']).pid
         self.addTearDownHook(self.cleanupSubprocesses)
 
         if self.TraceOn():

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7661.20000.patch
Type: text/x-patch
Size: 718 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150216/fafa8f08/attachment.bin>


More information about the lldb-commits mailing list