[Lldb-commits] [PATCH] Fix the variable printing for stack-list-local and stack-list-arguments.

[Ilia K]

I have one more issue (sorry, forgot to say immediately about it):


================
Comment at: tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp:760-762
@@ -773,6 +759,5 @@
 //--
 bool
 CMICmnLLDBDebugSessionInfo::GetVariableInfo(const MIuint vnMaxDepth, const lldb::SBValue &vrValue, const bool vbIsChildValue,
-                                            const VariableInfoFormat_e veVarInfoFormat, CMICmnMIValueList &vwrMiValueList,
-                                            MIuint &vrwnDepth)
+                                            CMICmnMIValueList &vwrMiValueList, MIuint &vrwnDepth)
 {
----------------
```
bool
CMICmnLLDBDebugSessionInfo::GetVariableInfo(const MIuint vnMaxDepth, const lldb::SBValue &vrValue, const bool vbIsChildValue,
                         const MIuint vnDepth, CMICmnMIValueList &vwrMiValueList)
```

================
Comment at: tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp:840-842
@@ -1081,1 +839,5 @@
+            lldb::SBValue member = rValue.GetChildAtIndex(i);
+            vrwnDepth++;
+            bOk = GetVariableInfo(vnMaxDepth, member, true, miValueList2, vrwnDepth);
+            vrwnDepth--;
         }
----------------
```
bOk = GetVariableInfo(vnMaxDepth, member, true, vnDepth + 1, miValueList2);
```

================
Comment at: tools/lldb-mi/MICmnLLDBDebugSessionInfo.h:203
@@ -204,5 +202,3 @@
     bool GetVariableInfo(const MIuint vnMaxDepth, const lldb::SBValue &vrValue, const bool vbIsChildValue,
-                         const VariableInfoFormat_e veVarInfoFormat, CMICmnMIValueList &vwrMiValueList, MIuint &vrwnDepth);
-    bool GetVariableInfo2(const MIuint vnMaxDepth, const lldb::SBValue &vrValue, const bool vbIsChildValue,
-                          const VariableInfoFormat_e veVarInfoFormat, CMICmnMIValueList &vwrMiValueList, MIuint &vrwnDepth);
+                         CMICmnMIValueList &vwrMiValueList, MIuint &vrwnDepth);
 
----------------
I'd prefer "const MIuint vnDepth". And it will be great if you make the vnDepth 4th argument (and move vwrMiValueList to the end).
```
bool GetVariableInfo(const MIuint vnMaxDepth, const lldb::SBValue &vrValue, const bool vbIsChildValue,
                         const MIuint vnDepth, CMICmnMIValueList &vwrMiValueList);
```

http://reviews.llvm.org/D7589

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/