[Lldb-commits] [PATCH] Merge lldb-platform and lldb-gdbserver into a single binary.

Robert Flack flackr at gmail.com
Thu Feb 12 11:46:01 PST 2015


I'll update as soon as I get a mac to test on.


REPOSITORY
  rL LLVM

================
Comment at: tools/lldb-server/lldb-gdbserver.cpp:57-58
@@ +56,4 @@
+
+namespace
+{
+
----------------
tberghammer wrote:
> Please make the functions and the global variables static instead of using an anonymous namespace.
Done.

================
Comment at: tools/lldb-server/lldb-platform.cpp:42-43
@@ +41,4 @@
+
+namespace
+{
+
----------------
tberghammer wrote:
> Please make the functions and the global variables static instead of using an anonymous namespace.
Done.

http://reviews.llvm.org/D7545

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list