[Lldb-commits] [PATCH] Fix argdumper build in cmake (OS X) after r228636

Zachary Turner zturner at google.com
Thu Feb 12 10:48:44 PST 2015


In the future, please try to test the python changes more thoroughly.  I know we can't expect everyone to test everything on every platform, but I'm not sure this was tested at all.  There were lots of places **not** in Windows specific codepaths that had syntax errors.  Like calling a function that didn't exist, returning a local variable of the wrong name, spaces instead of tabs, and more.

I'm glad that there's more people digging into this stuff, but please make sure to test sufficiently.  I'm uploading a new version of this which makes it work insofar as I can test.  Please feel free to download this revision and make sure it works on other platforms.


http://reviews.llvm.org/D7550

Files:
  scripts/Python/finish-swig-Python-LLDB.sh
  scripts/Python/finishSwigPythonLLDB.py
  source/CMakeLists.txt
  test/functionalities/launch_with_glob/TestLaunchWithGlob.py
  tools/CMakeLists.txt
  tools/argdumper/CMakeLists.txt

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7550.19845.patch
Type: text/x-patch
Size: 17894 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150212/949ed183/attachment.bin>


More information about the lldb-commits mailing list