[Lldb-commits] [PATCH] RFC: Proposed change in the disassembly default format in lldb

[Jason Molenda]

Initially I had this using "*" to mean current-function.  So offsets were expressed like <*+36> but when it was all said and done, the "*" wasn't adding any information so I nixed it.  If the <>'s weren't present, the * would be necessary but I think with the offset in the brackets, it's not needed.  I'm not wedded to omitting the "*" but I think we're fine without it.  I definitely don't want to lose the "+" and have the offsets expressed as "<30>" - that seems a little too much.

I originally was trying to think of a way to alternate the disassembly style based on the function name length.  But that makes it hard to have a `disassembly-format` customization capability unless there was a `disassembly-format-short-names` and `disassembly-format-long-names` ;).  And someone argued that it would be more confusing to users if we have multiple styles of disassembly formatting depending on the length of the function name -- people aren't going to know why the disassembler formats it one way for certain functions and a different way for a slightly longer function name function.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7578

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/