[Lldb-commits] [PATCH] Fix argdumper build in cmake (OS X) after r228636

Zachary Turner zturner at google.com
Wed Feb 11 14:46:38 PST 2015

Comment at: scripts/Python/finishSwigPythonLLDB.py:466-468
@@ +465,5 @@
+	if bOk:
+		bOk, strErrMsg = make_symlink_argdumper( vDictArgs,
+												 vstrFrameworkPythonDir,
+												 strArgdumperFileName );
I think this won't work on Windows as written?  The previous code was using make_symlink_windows() and make_symlink_other_platforms.  make_symlink_windows makes a hardlink because os.symlink is not supported on Windows for some reason.  So I think make_symlink_argdumper() should do the same.  It would be nice if we wrapped this into an lldb_make_symlink(source, target) or something, so we didn't have to worry about this in the future.



More information about the lldb-commits mailing list