[Lldb-commits] [PATCH] Merge lldb-platform and lldb-gdbserver into a single binary.
flackr at gmail.com
Wed Feb 11 14:04:28 PST 2015
I've kept the two in separate cpp files with a new cpp file for lldb-server which calls the main on one or the other.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp:493
@@ -492,3 +492,3 @@
// FIXME This looks an awful lot like we could override this in
- // derived classes, one for lldb-platform, the other for lldb-gdbserver.
+ // derived classes, one for platform, the other for gdbserver.
if (IsGdbServer ())
> I actually don't like lldb being removed from lldb-gdbserver. Then you just have something that doesn't make sense, because it isn't gdbserver. I think we should stick with lldb-gdbserver and also lldb-platform to differentiate the platform process from the platform command/concept.
More information about the lldb-commits