[Lldb-commits] [PATCH] Fix argdumper build in cmake (OS X) after r228636
zturner at google.com
Wed Feb 11 07:31:50 PST 2015
I was objecting to both things actually:
1) Disabled in the CMake build that Ilia ported
2) Test disabled on non mac.
We should be enabling tests in all platforms by default, and if it breaks
someone should be fixing the tests.
Also, I know you guys use the Xcode build primarily, but i think for large
changes like this it would be helpful to at least try to fix the CMake
build. Otherwise there's a good chance nobody will notice the change go
through and the feature will not be added to other builds until someday
when it breaks a test.
On Tue, Feb 10, 2015 at 10:47 PM Enrico Granata <egranata at apple.com> wrote:
> I would have no objection to disabling the Darwin only marker for the
> DWARF test, and seeing what happens on non-Mac.
> If that test marking is what Zachary was referring to as "Mac-only" then -
> my bad - it was not intentional. argdumper should be compilable and
> runnable on pretty much any sane system.
> What we don't do is remote argdumper - as in, I won't compile argdumper,
> send it over to a remote system for execution, and retrieve the output
> Sent from my iPhone
> > On Feb 10, 2015, at 10:42 PM, Ilia K <ki.stfu at gmail.com> wrote:
> > Tests were marked as "Darwin only" (see test/functionalities/launch_
> with_glob/TestLaunchWithGlob.py), therefore I have fixed it only for os x.
> > http://reviews.llvm.org/D7550
> > EMAIL PREFERENCES
> > http://reviews.llvm.org/settings/panel/emailpreferences/
> > _______________________________________________
> > lldb-commits mailing list
> > lldb-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits