[Lldb-commits] [lldb] r228707 - Fixed a problem where we might omit some breakpoints when using DWARF in .o files.

Greg Clayton gclayton at apple.com
Tue Feb 10 08:53:40 PST 2015


Author: gclayton
Date: Tue Feb 10 10:53:40 2015
New Revision: 228707

URL: http://llvm.org/viewvc/llvm-project?rev=228707&view=rev
Log:
Fixed a problem where we might omit some breakpoints when using DWARF in .o files.

The problem occurred when we had incorrect address ranges in the debug map that included the padding between functions causing the end address of a line table entry to fall into an inlinked (next function) address range.

<rdar://problem/19721144>


Modified:
    lldb/trunk/source/Symbol/LineTable.cpp

Modified: lldb/trunk/source/Symbol/LineTable.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/LineTable.cpp?rev=228707&r1=228706&r2=228707&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/LineTable.cpp (original)
+++ lldb/trunk/source/Symbol/LineTable.cpp Tue Feb 10 10:53:40 2015
@@ -542,8 +542,7 @@ LineTable::LinkLineTable (const FileRang
             // This entry doesn't have a remapping and it needs to be removed.
             // Watch out in case we need to terminate a previous entry needs to
             // be terminated now that one line entry in a sequence is not longer valid.
-            if (!entry.is_terminal_entry &&
-                !sequence.m_entries.empty() &&
+            if (!sequence.m_entries.empty() &&
                 !sequence.m_entries.back().is_terminal_entry)
             {
                 terminate_previous_entry = true;





More information about the lldb-commits mailing list