[Lldb-commits] [PATCH] Fix CMIUtilString::SplitConsiderQuotes (MI)

Ilia K ki.stfu at gmail.com
Tue Feb 10 04:42:48 PST 2015


Hi abidh, clayborg, emaste,

This method doesn't work properly. Here is an example:
```
CMIUtilString test("\"hello\" \"\\\" world \\\" !\"");
CMIUtilString::VecString_t res;
test.SplitConsiderQuotes(" ", res);
```

Before this patch the result was as following:
```
(lldb) print res
(CMIUtilString::VecString_t) $1 = size=4 {
  [0] = (std::__1::string = "\"hello\"")
  [1] = (std::__1::string = "\"\\\"")
  [2] = (std::__1::string = "world")
  [3] = (std::__1::string = "\\\" !\"")
}
```

This patch fixes that error and now it looks like following:
```
(lldb) print res
(CMIUtilString::VecString_t) $1 = size=2 {
  [0] = (std::__1::string = "\"hello\"")
  [1] = (std::__1::string = "\"\\\" world \\\" !\"")
}
```

http://reviews.llvm.org/D7532

Files:
  tools/lldb-mi/MIUtilString.cpp
  tools/lldb-mi/MIUtilString.h

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7532.19665.patch
Type: text/x-patch
Size: 11215 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150210/87aa246a/attachment.bin>


More information about the lldb-commits mailing list