[Lldb-commits] [PATCH] Use GUIDs to make pipe names unique on Windows.

Zachary Turner zturner at google.com
Mon Feb 9 14:37:58 PST 2015


================
Comment at: source/Host/windows/PipeWindows.cpp:109
@@ -101,6 +108,3 @@
         pipe_name += "-";
-        for (unsigned i = 0; i < 6; i++) {
-            pipe_name += "0123456789abcdef"[llvm::sys::Process::GetRandomNumber() & 15];
-        }
-        Error error = CreateNew(pipe_name, child_process_inherit);
-    } while (error.GetError() == ERROR_ALREADY_EXISTS);
+        pipe_name += *unique_string;
+        ::RpcStringFreeA(&unique_string);
----------------
Does this just only append the first character to the string?  Seems like it should just be unique_string.  Otherwise lgtm.  I can commit later.

http://reviews.llvm.org/D7509

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list