[Lldb-commits] [PATCH] Fix the LLDB build under Debian Kfreebsd

Ed Maste emaste at freebsd.org
Mon Feb 9 12:33:00 PST 2015


LGTM other than sorting the lists in alpha order. In the future would you mind uploading with full context (e.g., using -U99999)?


================
Comment at: source/Host/common/Host.cpp:1057
@@ -1056,3 +1056,3 @@
 
-#if !defined (__linux__) && !defined (__FreeBSD__) && !defined (__NetBSD__)
+#if !defined (__linux__) && !defined (__FreeBSD__) && !defined (__NetBSD__) && !defined(__FreeBSD_kernel__)
 
----------------
Do you mind re-sorting these in alpha order? Minor point, but I think it would make things more clear when future changes come along (e.g. adding __OpenBSD__ or refactoring this into some catch-all #define)

http://reviews.llvm.org/D7441

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list