[Lldb-commits] [PATCH] Fix descriptor leak in multi-target debugging

[Ed Maste]

I can't fully confirm the fix on FreeBSD at the moment due to python leaking an fd, but LGTM.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197376 but


================
Comment at: source/Utility/PseudoTerminal.cpp:262
@@ -262,1 +261,3 @@
+
+                // Master FD should have O_CLOEXEC set, but let's close it just in case...
                 CloseMasterFileDescriptor ();
----------------
in case O_CLOEXEC fails or is unsupported?

http://reviews.llvm.org/D7466

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/