[Lldb-commits] [PATCH] Fix TestThreadSpecificBreakpoint with LLGS

[Oleksiy Vyalov]

Please make sure that there are no test regressions with LLGS_LOCAL on.


================
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:2612
@@ +2611,3 @@
+                                                               // Pass this signal number on to the inferior to handle.
+                                                               SetState(eStateRunning, true);
+                                                               return Resume (tid_to_resume, (signo > 0 && !supress_signal) ? signo : LLDB_INVALID_SIGNAL_NUMBER);
----------------
Should we update process state only if the following Resume call succeeds?

================
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:2627
@@ +2626,3 @@
+                                                       reinterpret_cast<NativeThreadLinux*> (thread_sp.get ())->SetStepping ();
+                                                       SetState(eStateStepping, true);
+                                                       const auto step_result = SingleStep (tid_to_step,(signo > 0 && !supress_signal) ? signo : LLDB_INVALID_SIGNAL_NUMBER);
----------------
Should we update process state only if the following SingleStep call succeeds?

================
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:2727
@@ -2728,1 +2726,3 @@
 
+    Mutex::Locker locker (m_threads_mutex);
+
----------------
minor optimization - could you move locker down to "for (auto thread_sp : m_threads)"?

http://reviews.llvm.org/D7374

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/