[Lldb-commits] [PATCH] Avoid leakage of file descriptors in LLDB and LLGS

[Oleksiy Vyalov]

The CL is causing TestProcessLaunch.py regression.


REPOSITORY
  rL LLVM

================
Comment at: lldb/trunk/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1551
@@ +1550,3 @@
+        // leaking descriptors to the debugged process.
+        terminal.CloseSlaveFileDescriptor();
+
----------------
This statement makes TestProcesslaunch.test_io_with_dwarf to fail with SIGHUP:

runCmd: process launch -i /usr/local/google/home/ovyalov/projects/lldb/dev/lldb/test/functionalities/process_launch/input-file.txt -o /usr/local/google/home/ovyalov/projects/lldb/dev/lldb/test/functionalities/process_launch/output-test.out -e /usr/local/google/home/ovyalov/projects/lldb/dev/lldb/test/functionalities/process_launch/output-test.err
output: Process 25324 launching
Process 25324 stopped
* thread #1: tid = 25324, 0x00007ffff7ddb2d0, name = 'a.out', stop reason = signal SIGHUP
    frame #0: 0x00007ffff7ddb2d0
-> 0x7ffff7ddb2d0: movq   %rsp, %rdi
   0x7ffff7ddb2d3: callq  0x7ffff7ddea70
   0x7ffff7ddb2d8: movq   %rax, %r12
   0x7ffff7ddb2db: movl   0x221b17(%rip), %eax

http://reviews.llvm.org/D7372

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/