[Lldb-commits] [PATCH] Remove autogenerated makefiles after running tests

Zachary Turner zturner at google.com
Wed Feb 4 11:06:11 PST 2015


Right, so now the issue is that the test runner tries to delete a file
which is checked in, causing git to detect changes.  Do we change the test
runner to never delete generated Makefiles?  It seems like there was some
contention about that last time I ran into this problem.  It's all very
flaky right now, because the generated filename is the same as the checked
in filename.  We should make a decision, probably from the following list:

1) The test runner will always generate Makefiles, and Makefiles will never
be checked in
2) The test runner will never generate Makefiles, and Makefiles will always
be checked in
3) The test runner will generate Makefiles whenever it wants, but with
*different
names* than those of the files that are checked in.

On Wed Feb 04 2015 at 10:58:07 AM Greg Clayton <clayborg at gmail.com> wrote:

> Please just check the Makefile files in, don't remove them. Why? Because
> when this test fails, I want to be able to go to each directory and type
> "make" and then be able to debug it. If there are no makefiles, you can
> only run it by running the inline test. This is why the Makefiles were left
> there. So just run these tests once and check in any Makefile files that
> are not already checked in.
>
>
> http://reviews.llvm.org/D7407
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150204/52230009/attachment.html>


More information about the lldb-commits mailing list